Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename brevitas quant custom op #693

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Rename brevitas quant custom op #693

merged 1 commit into from
Aug 17, 2023

Conversation

jinchen62
Copy link
Contributor

I have tested the op would be torch.operator "quant.matmul_rhs_group_quant".

@jinchen62
Copy link
Contributor Author

Pls review, thanks! @Giuseppe5 @volcacius @ harish

@Giuseppe5
Copy link
Collaborator

Would you be able to run
pre-commit run --all-files

And add also the changes that cause the pre-commit check to fail?
It should be changing something in one of the files you are already modifying.

Thanks!

@Giuseppe5 Giuseppe5 merged commit 993307a into Xilinx:dev Aug 17, 2023
19 of 22 checks passed
@jinchen62 jinchen62 deleted the dev_rename_custom_op branch August 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinchen62 @Giuseppe5